Skip to content

Commit

Permalink
ci: prettier, drop node 19 (#790)
Browse files Browse the repository at this point in the history
* ci: run prettier against everything

* chore: run prettier

* chore: reorganize ci jobs

* ci: do this instead

* ci: rename job, stop running against node 19
  • Loading branch information
kanadgupta authored Aug 14, 2023
1 parent 190a6c7 commit 5243635
Show file tree
Hide file tree
Showing 17 changed files with 1,816 additions and 1,618 deletions.
14 changes: 7 additions & 7 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
{
"extends": [
"@readme/eslint-config",
"@readme/eslint-config/typescript"
],
"extends": ["@readme/eslint-config", "@readme/eslint-config/typescript"],
"root": true,
"rules": {
"@typescript-eslint/no-explicit-any": "off",
Expand All @@ -13,8 +10,11 @@
"max-classes-per-file": "off",
"no-param-reassign": "off",

"no-underscore-dangle": ["error", {
"allow": ["_key"]
}]
"no-underscore-dangle": [
"error",
{
"allow": ["_key"]
}
]
}
}
4 changes: 2 additions & 2 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: 2
updates:
- package-ecosystem: github-actions
directory: "/"
directory: '/'
schedule:
interval: monthly
allow:
Expand All @@ -15,7 +15,7 @@ updates:
prefix-development: chore(deps-dev)

- package-ecosystem: npm
directory: "/"
directory: '/'
schedule:
interval: monthly
allow:
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,13 @@ on:
pull_request:

jobs:
build:
test:
runs-on: ubuntu-latest
strategy:
matrix:
node-version:
- 16
- 18
- 19
- 20

steps:
Expand All @@ -25,11 +24,12 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- name: Install deps
run: npm ci
- name: Install deps and run tests
run: npm cit

- name: Build dist
run: npm run build

- name: Run tests
run: npm test
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- run: npm ci
- run: npm run lint
20 changes: 10 additions & 10 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "CodeQL"
name: 'CodeQL'

on:
push:
Expand All @@ -20,16 +20,16 @@ jobs:
strategy:
fail-fast: false
matrix:
language: [ 'javascript' ]
language: ['javascript']

steps:
- name: Checkout repository
uses: actions/checkout@v3
- name: Checkout repository
uses: actions/checkout@v3

- name: Initialize CodeQL
uses: github/codeql-action/init@v2
with:
languages: ${{ matrix.language }}
- name: Initialize CodeQL
uses: github/codeql-action/init@v2
with:
languages: ${{ matrix.language }}

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
20 changes: 0 additions & 20 deletions .github/workflows/lint-docs.yml

This file was deleted.

127 changes: 63 additions & 64 deletions __tests__/__datasets__/3-1-no-responses.json
Original file line number Diff line number Diff line change
@@ -1,74 +1,73 @@
{
"openapi": "3.1.0",
"servers": [
{
"url": "http://petstore.swagger.io/v2"
}
],
"info": {
"description":
"This file tests oas 3.1's ability to have operations without responses",
"version": "1.0.0",
"title": "3.1.0 without responses",
"license": {
"name": "Apache 2.0",
"url": "http://www.apache.org/licenses/LICENSE-2.0.html"
}
},
"paths": {
"/pet/{petId}": {
"delete": {
"tags": ["pet"],
"summary": "Deletes a pet",
"description": "",
"operationId": "deletePet",
"parameters": [
{
"name": "api_key",
"in": "header",
"required": false,
"schema": {
"type": "string"
}
},
{
"name": "petId",
"in": "path",
"description": "Pet id to delete",
"required": true,
"schema": {
"type": "integer",
"format": "int64"
}
"openapi": "3.1.0",
"servers": [
{
"url": "http://petstore.swagger.io/v2"
}
],
"info": {
"description": "This file tests oas 3.1's ability to have operations without responses",
"version": "1.0.0",
"title": "3.1.0 without responses",
"license": {
"name": "Apache 2.0",
"url": "http://www.apache.org/licenses/LICENSE-2.0.html"
}
},
"paths": {
"/pet/{petId}": {
"delete": {
"tags": ["pet"],
"summary": "Deletes a pet",
"description": "",
"operationId": "deletePet",
"parameters": [
{
"name": "api_key",
"in": "header",
"required": false,
"schema": {
"type": "string"
}
],
"security": [
{
"petstore_auth": ["write:pets", "read:pets"]
},
{
"name": "petId",
"in": "path",
"description": "Pet id to delete",
"required": true,
"schema": {
"type": "integer",
"format": "int64"
}
]
}
}
],
"security": [
{
"petstore_auth": ["write:pets", "read:pets"]
}
]
}
},
"components": {
"securitySchemes": {
"petstore_auth": {
"type": "oauth2",
"flows": {
"implicit": {
"authorizationUrl": "http://petstore.swagger.io/oauth/dialog",
"scopes": {
"write:pets": "modify pets in your account",
"read:pets": "read your pets"
}
}
},
"components": {
"securitySchemes": {
"petstore_auth": {
"type": "oauth2",
"flows": {
"implicit": {
"authorizationUrl": "http://petstore.swagger.io/oauth/dialog",
"scopes": {
"write:pets": "modify pets in your account",
"read:pets": "read your pets"
}
}
},
"api_key": {
"type": "apiKey",
"name": "api_key",
"in": "header"
}
},
"api_key": {
"type": "apiKey",
"name": "api_key",
"in": "header"
}
}
}
}
Loading

0 comments on commit 5243635

Please sign in to comment.