-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(oas/exampleGroups): properly set name for code samples (#873)
## 🧰 Changes Fixes a few minuscule bugs with this `exampleGroups` object generation: - [x] We were previously adding names to nameless code samples regardless of their language (e.g., `Default #1` could be `shell` and the next nameless sample would be `Default #2` regardless of it was `shell` or not). We now properly split out our nameless sample counts by language - [x] We weren't properly tacking on these names to the code sample objects themselves - [x] Upgrades `oas-examples` to the latest This `exampleGroups` object has some wonky ergonomics that I'm already reckoning with but I can't seem to think of an alternative approach that warrants a breaking change. Stay tuned I guess? ## 🧬 QA & Testing Do tests still pass?
- Loading branch information
1 parent
46cd8bb
commit a8ce4b1
Showing
3 changed files
with
21 additions
and
13 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters