Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor code style improvements to fix phpstan analysis warnings #140

Merged
merged 1 commit into from
May 23, 2019
Merged

Minor code style improvements to fix phpstan analysis warnings #140

merged 1 commit into from
May 23, 2019

Conversation

realFlowControl
Copy link

@realFlowControl realFlowControl commented May 13, 2019 •
edited
Loading

This merge request fixes some small errors reported by phpstan. As phpstan requires PHP >= 7.1 we may not add it to composer as of now

@realFlowControl realFlowControl changed the title Add phpstan Fix phpstan analysis warnings May 14, 2019
@clue clue added this to the v1.1.1 milestone May 18, 2019
clue
clue approved these changes May 18, 2019
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flow-control Changes LGTM, thanks for the update! :shipit:

@clue clue changed the title Fix phpstan analysis warnings Minor code style improvements to fix phpstan analysis warnings May 18, 2019
@WyriHaximus WyriHaximus requested review from WyriHaximus and jsor May 18, 2019 14:34
WyriHaximus
WyriHaximus approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@WyriHaximus WyriHaximus merged commit a39db4f into reactphp:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clue clue clue approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@jsor jsor jsor approved these changes

Assignees
No one assigned
Labels
easy pick maintenance
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@realFlowControl @jsor @WyriHaximus @clue