Minor code style improvements to fix phpstan analysis warnings (#140)

Minor code style improvements to fix phpstan analysis warnings
reactphp · May 23, 2019 · a39db4f · a39db4f
2 parents 5042685 + 07140ba
commit a39db4f
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 4 deletions.
diff --git a/src/CompositeStream.php b/src/CompositeStream.php
@@ -16,7 +16,8 @@ public function __construct(ReadableStreamInterface $readable, WritableStreamInt
         $this->writable = $writable;
 
         if (!$readable->isReadable() || !$writable->isWritable()) {
-            return $this->close();
+            $this->close();
+            return;
         }
 
         Util::forwardEvents($this->readable, $this, array('data', 'end', 'error'));

diff --git a/src/DuplexResourceStream.php b/src/DuplexResourceStream.php
@@ -49,7 +49,7 @@ public function __construct($stream, LoopInterface $loop, $readChunkSize = null,
 
         // this class relies on non-blocking I/O in order to not interrupt the event loop
         // e.g. pipes on Windows do not support this: https://bugs.php.net/bug.php?id=47918
-        if (\stream_set_blocking($stream, 0) !== true) {
+        if (\stream_set_blocking($stream, false) !== true) {
             throw new \RuntimeException('Unable to set stream resource to non-blocking mode');
         }
 

diff --git a/src/ReadableResourceStream.php b/src/ReadableResourceStream.php
@@ -52,7 +52,7 @@ public function __construct($stream, LoopInterface $loop, $readChunkSize = null)
 
         // this class relies on non-blocking I/O in order to not interrupt the event loop
         // e.g. pipes on Windows do not support this: https://bugs.php.net/bug.php?id=47918
-        if (\stream_set_blocking($stream, 0) !== true) {
+        if (\stream_set_blocking($stream, false) !== true) {
             throw new \RuntimeException('Unable to set stream resource to non-blocking mode');
         }
 

diff --git a/src/WritableResourceStream.php b/src/WritableResourceStream.php
@@ -9,7 +9,15 @@ final class WritableResourceStream extends EventEmitter implements WritableStrea
 {
     private $stream;
     private $loop;
+
+    /**
+     * @var int
+     */
     private $softLimit;
+
+    /**
+     * @var int
+     */
     private $writeChunkSize;
 
     private $listening = false;
@@ -31,7 +39,7 @@ public function __construct($stream, LoopInterface $loop, $writeBufferSoftLimit
 
         // this class relies on non-blocking I/O in order to not interrupt the event loop
         // e.g. pipes on Windows do not support this: https://bugs.php.net/bug.php?id=47918
-        if (\stream_set_blocking($stream, 0) !== true) {
+        if (\stream_set_blocking($stream, false) !== true) {
             throw new \RuntimeException('Unable to set stream resource to non-blocking mode');
         }