Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove event listeners from CompositeStream once closed and remove remove undocumented left-over close event argument #116

Merged
merged 2 commits into from
Oct 11, 2017

Conversation

clue
Copy link
Member

@clue clue commented Oct 10, 2017

This simple PR ensures that pending event listeners are removed after closing the (rarely used) CompositeStream in order to simplify garbage collection.

Builds on top of #107 and #69

@clue clue added this to the v0.7.4 milestone Oct 10, 2017
@WyriHaximus WyriHaximus merged commit 1da4a66 into reactphp:master Oct 11, 2017
@clue clue deleted the close branch October 11, 2017 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants