Close the underlying stream when closing the stream #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for spotting this bug and filing this PR! 👍 I agree that your suggested fix makes sense and the two tests need to be updated because they rely on some rather pointless assumptions. One possible option would be using a writer filter function instead of rewinding after close. Does this make sense to you? |
The idea makes sense, not sure yet how to implement that right now. |
|
Doh your package make it very easy ❤️ ! Ping @clue and @jsor, tests have been fixed and are green across the board. |
clue
approved these changes
Jun 13, 2017
jsor
approved these changes
Jun 14, 2017
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently unlike
ReadableResourceStreamtheWritableResourceStreamdoesn't automatically closes the underlying stream resource withfclose. This PR aims to add that, but as of creating this PR two tests fail, purposely not updated tests to discuss how to handle those here before fixing them.