Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal improvement to avoid unhandled rejection for future Promise API #258

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

clue
Copy link
Member

@clue clue commented Jun 25, 2021

This changeset applies some internal improvements to avoid unhandled rejection for future Promise API. This does not affect current behavior in any way (test cases are unaffected), but makes sure we do not use any unhandled promise rejections anymore. As discussed in reactphp/promise#87 this could otherwise raise some error/warning in future.

Resolves / closes #248
Refs #214

@clue clue added this to the v1.7.0 milestone Jun 25, 2021
@clue clue requested a review from WyriHaximus June 25, 2021 10:29
@WyriHaximus WyriHaximus merged commit 43c9f20 into reactphp:master Jun 25, 2021
@clue clue deleted the unhandled-rejection branch June 25, 2021 11:48
tom-fleming added a commit to massgov/logs-acquia-to-newrelic that referenced this pull request Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignoring exceptions from HappyEyeBallsConnectionBuilder::resolve
2 participants