Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring exceptions from HappyEyeBallsConnectionBuilder::resolve #248

Closed
Provoker opened this issue Sep 10, 2020 · 2 comments · Fixed by #258
Closed

Ignoring exceptions from HappyEyeBallsConnectionBuilder::resolve #248

Provoker opened this issue Sep 10, 2020 · 2 comments · Fixed by #258
Assignees
Labels
Milestone

Comments

@Provoker
Copy link

HappyEyeBallsConnectionBuilder::connect ignores rejection HappyEyeBallsConnectionBuilder::resolve if there is no A or AAAA dns entry.

This fact has no effect in the current implementation of promise, but if you add a detector of unhandled rejections, it will cause problems.
And based on your plans, this detector will still be added (reactphp/promise#170) and the problem will still have to be corrected.

We are already using our own implementation of handling uncaught rejections at the moment and this problem prevents us from upgrading to a version higher than 1.3.0.

@WyriHaximus WyriHaximus self-assigned this Sep 12, 2020
@WyriHaximus WyriHaximus added this to the v1.7.0 milestone Sep 12, 2020
@WyriHaximus
Copy link
Member

Hey @Provoker thank you for reporting this bug. But "issue" might have slipped by us when implementing Happy Eyeballs. You can still update to 1.6, and disable happy eyeballs as documented at https://reactphp.org/socket/#connector with the following snippet:

$connector = new React\Socket\Connector($loop, array(
    'happy_eyeballs' => false
));

I'll have a look at this this week and come up with a fix 👍

@WyriHaximus
Copy link
Member

@Provoker just filed #251 to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment