Support union types and address deprecation of ReflectionType::getClass() (PHP 8+ / Promise v2)
#198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonFrings
force-pushed
the
types
branch
3 times, most recently
from
36512e5 to
5eca8a7
Compare
SimonFrings
changed the title
SimonFrings
force-pushed
the
types
branch
2 times, most recently
from
7dffc7a to
290305c
Compare
SimonFrings
changed the title
clue
changed the title
ReflectionType::getClass() (PHP 8+ / Promise v2)
clue
changed the title
ReflectionType::getClass() (PHP 8+ / Promise v2)ReflectionType::getClass() (PHP 8+ / Promise v2)
clue
approved these changes
Nov 4, 2021
There was a problem hiding this comment.
@SimonFrings Thanks for backporting this from #197, changes LGTM! 
jsor
approved these changes
Nov 4, 2021
WyriHaximus
approved these changes
Nov 6, 2021
Closed
|
Thanks alot for fixing this! @clue: Do you guys know, when the v2.9.0 will be released with it? |
|
@pflueg Indeed discussed this earlier today and will look into this asap, hope to have something ready in the next couple of weeks! |
|
Cool - thanks for your efforts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For references concerning this pull request look into #197 and #176.