-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support union types and address deprecation of ReflectionType::getClass()
(PHP 8+)
#197
Conversation
In response to #195's comment
Obviously 👍 for a fix. I feel though that there is some depth in the discussion about intersection types in #195. It may make sense to look at the discussion/implementation and incroporate it into the final decision. |
As discussed in #197 I think both PRs add value, so I'm all for getting in both! I would suggest we use this PR as a starting point as it adds support for union types as present as of PHP 8.0 and the required test suite. Once this is merged, perhaps we can update #197 to build on top of this and add additional tests for intersection types (future PHP 8.1+)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimonFrings Thank you for taking this over and thank you @cdosoftei for the original changes!
The changes LGTM, let's get this in and then look into intersection types in a follow-up PR (see #195)
I just realized: This got merged into Related: Do you want me to target |
ReflectionType::getClass()
(PHP 8+)
@bzikarsky I agree, this is indeed somewhat confusing. Here's the rundown:
I'll make sure to review your PR #195 and leave a comment to see how we can get this shipped asap |
Big thank you to @cdosoftei for putting the time and effort into these changes!
He's done all the work in #176, I only rearranged some commits and added PHP 8 to the test matrix.
This pull request builds on top of #176, #195 and #196.
Resolves and Closes #176.