Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Parser: Multipart #72

Closed
wants to merge 128 commits into from
Closed

[WIP] Parser: Multipart #72

wants to merge 128 commits into from

Conversation

WyriHaximus
Copy link
Member

@WyriHaximus WyriHaximus commented Oct 5, 2016 •
edited
Loading

Adds a multipart parser and updates the parser factory (#69) to utilize that parser when applicable.

Depends on #69 and #62

@WyriHaximus WyriHaximus changed the title [WIP] Feature multipart parser [WIP] Parser: Multipart Oct 8, 2016
@WyriHaximus WyriHaximus mentioned this pull request Oct 8, 2016
Closed
8 tasks
@andig
Copy link
Contributor

andig commented Nov 30, 2016

The test failure with missing ParserInterface looks imho intermittent?

@WyriHaximus
Copy link
Member Author

@andig yes it needs the PR's it depends on in first before everything can pass correctly

@WyriHaximus WyriHaximus self-assigned this Nov 30, 2016
@WyriHaximus WyriHaximus added this to the v0.5.1 milestone Nov 30, 2016
@WyriHaximus WyriHaximus changed the base branch from master to 0.5 November 30, 2016 20:34
@clue clue modified the milestone: v0.5.1 Feb 14, 2017
@clue clue closed this Feb 16, 2017
@clue clue changed the base branch from 0.5 to master February 16, 2017 14:46
@clue clue reopened this Feb 16, 2017
@clue clue modified the milestone: v0.8.0 Feb 16, 2017
WyriHaximus and others added 13 commits May 31, 2017 07:38
@WyriHaximus
Remove all listeners after emitting error in RequestHeaderParser (rea…
5ef8f76 
…ctphp#68)

* Ensure removeAllListeners on all error event in RequestHeaderParser

* Ensure all error events from RequestHeaderParser emit $this as second item in event

* Reverted emitting $this with error
@WyriHaximus
Added 0.4.2 to changelog
0385533
@WyriHaximus
Removed testing against HHVM nightly (reactphp#66)
56f09cd 
* Test against PHP 7.1 and not against HHVM nightly anymore

* Removed 7.1 to not overly bloat the test matrix

* Changed 7.0 back to 7 so the effective changes are only what the PR is about now
@WyriHaximus
Typo in $reques, should be $request
409defb
@WyriHaximus
Fixes reactphp#81 issue: data listener is removed if HeaderParser emi…
a993fd1 
…ts error (reactphp#83)
@nopolabs @WyriHaximus
check max header size
a05c1c2
@nopolabs @WyriHaximus
add phpunit 4.8 to require-dev, force travisci to use local phpunit
12a8282
@nopolabs @WyriHaximus
replace getMock for forward compatibility
49b5794
@legionth @WyriHaximus
ServerInterface is unnecessary
d1c3356
@legionth @WyriHaximus
Fix assertion in ServerTests
9e03e07
@legionth @WyriHaximus
Remove unneeded type hints
9b10bd4
@legionth @WyriHaximus
Remove stubs from server tests
30ff0bf
@legionth @WyriHaximus
Remove unneeded stubs
7c51dd3
clue and others added 26 commits May 31, 2017 07:39
@clue @WyriHaximus
Validate proxy requests in absolute-form
c4463f5
@clue @WyriHaximus
Use socket address for URI if Host header is missing
c77accb
@clue @WyriHaximus
Simplify request validation by moving logic to RequestHeaderParser
440ab68
@clue @WyriHaximus
Sanitize Host header value across all requests
d973e40
@clue @WyriHaximus
Move complete URI handling to RequestHeaderParser
eac22d2
@legionth @WyriHaximus
Add server-side parameters to implementation
75b7dee
@legionth @WyriHaximus
Update docs and add example
be143dd
@legionth @WyriHaximus
Add query parameters to ServerRequest
e570bb6
@legionth @WyriHaximus
Update README
fa17cf7
@legionth @WyriHaximus
Add function to parse cookies
ee49ccb
@legionth @WyriHaximus
Parse cookie for request object
a180831
@legionth @WyriHaximus
Add description and example
190ebd4
@clue @WyriHaximus
Forward compatibility with Socket v1.0 and v0.8
6a03ff4
@clue @WyriHaximus
Forward compatibility with Stream v1.0 and v0.7
8969bbf
@clue @WyriHaximus
Simplify buffering tests by using new react/promise-stream release
3dcc5ec
@clue @WyriHaximus
Ignore HHVM test failures for now until Travis tests work again
9a9971f
@clue @WyriHaximus
Automatically cancel pending promises once client connection closes
aaa70b0
@clue @WyriHaximus
Send empty response body for closed response body stream
93a963e
@clue @WyriHaximus
Automatically close response stream if connection closes
1573e89
@clue @WyriHaximus
Validate request-target of CONNECT in RequestHeaderParser
4908d32
@clue @WyriHaximus
Use duplex stream response body for CONNECT requests
961f8f0
@clue @WyriHaximus
Support Upgrade header such as Upgrade: WebSocket or custom protocols
b9ed029
@clue @WyriHaximus
Fix reporting listening addresses in examples
9a8a536
@clue @WyriHaximus
Add listen() method to support multiple listening sockets
748e456
@clue @WyriHaximus
Prepare v0.7.0 release
f4bc564
@WyriHaximus
Converted MultipartParser to use PSR-7 request with a HttpBodyStream
9ab8d84
@WyriHaximus
Copy link
Member Author

Hmmm seem I've messed the rebase up. I'll file new PR's for all the body parser stuff to avoid issues like this

@WyriHaximus WyriHaximus mentioned this pull request Jun 12, 2017
Closed
@clue clue removed this from the v0.8.0 milestone Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@WyriHaximus WyriHaximus

Labels
new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WyriHaximus @andig @clue @nopolabs @legionth