Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Uri class for new PSR-7 implementation #521

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

clue
Copy link
Member

@clue clue commented Mar 25, 2024

This changeset adds a new Uri class that builds on top of our new PSR-7 implementation. This brings us one step closer to eventually replace the dated RingCentral implementation (#331) and eventually support PSR-7 v2 (#513). This is a mostly an internal change, but also exposes the new Uri class as part of our public API. Perhaps most notably, this means the Request and ServerRequest classes will now return instances of our Uri class (#519) instead of using the legacy RingCentral classes. It comes with 100% code coverage and does not otherwise affect the public API, so it should be safe to apply.

This builds on top of the recent changes for the Response and ServerRequest classes (#518 and #519), but this similar to #520 doesn't show a noticeable impact on performance during my benchmarks. As a consequence, I consider this mostly a simple feature addition only.

Once merged, I'll file follow-up PRs to remove any leftover references to the old RingCentral implementation accordingly. If you enjoy this change and want to help us continue to ship more improvements, consider supporting this project, for example by becoming a sponsor ❤️

Builds on top of #520, #519, #518, #480, #432, #370, #170 and others

@clue clue added this to the v1.10.0 milestone Mar 25, 2024
@clue clue requested review from WyriHaximus and SimonFrings March 25, 2024 15:06
@clue clue force-pushed the psr7-uri branch 2 times, most recently from 4e815b6 to 5c5b426 Compare March 25, 2024 15:26
Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's get this in 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants