-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why ringcentral/psr7 and not guzzle/psr7 #331
Comments
See #319 |
Mmmhh ok, sorry for the duplicate. |
"Why guzzle/psr7 and not ringcentral/psr7?" :-) I would argue that it doesn't really make much of a difference which PSR-7 implementation we're using. For the most part, this is an internal implementation detail that is not in any way exposed to the outside and our documentation explicitly says we're using PSR-7 interfaces only. While I can see where you're coming from, I don't think discussing PHP version requirements adds much to this specific discussion. Additionally, there are plans to drop RingCentral in a future version. Partly because it adds a lot of stuff that we don't really use here (sync file handling etc.) and partly because it's missing some stuff that we do need here (async implementations etc.). I believe this has been answered, so I'm closing this for now. Please come back with more details if this problem persists and we can reopen this 👍 |
Hi,
this is just a question, not an issue.
Why do you require
ringcentral/psr7
from https://github.com/ringcentral/psr7 and notguzzle/psr7
from https://github.com/guzzle/psr7 ?I see ringcentral is a fork of guzzle, but it doesn't explain why, and what's changed.
Wouldn't guzzle be a better choice?
The text was updated successfully, but these errors were encountered: