Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal refactoring and improvement to hold message body in memory #431

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

clue
Copy link
Member

@clue clue commented Nov 7, 2021

This changeset only performs some internal refactoring and minor improvements to reuse the existing BufferedBody class (introduced via #395) to hold any message body in memory.

Prior to this change, it leaves this up to the underlying PSR-7 implementation which happens to use a temporary memory stream. With these changes, we no longer need to interface with streams and resources internally which happens to improve performance slightly (9200 req/s -> 9300 req/s). On top of this, dumping an HTTP message now shows the actual body contents instead of a resource, so this definitely makes debugging much easier.

This also makes us less dependent on the underlying PSR-7 implementation which allows us to possibly change this in the future (#331).

These changes do not otherwise affect the public API.

Builds on top of #395

@clue clue added this to the v1.6.0 milestone Nov 7, 2021
@clue clue requested a review from WyriHaximus November 7, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants