This repository has been archived by the owner on Oct 26, 2018. It is now read-only.
Add Dev tools #70
Merged
Add Dev tools #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| @@ -21,7 +21,7 @@ module.exports = { | |||
| // This will make the redux-simpler-router module resolve to the | |||
| // latest src instead of using it from npm. Remove this if running | |||
| // outside of the source. | |||
| var src = path.join(__dirname, '..', '..', 'src') | |||
| var src = path.join(__dirname, '..', '..', 'lib') | |||
There was a problem hiding this comment.
Please remove this change. We want to pull the latest source, not the latest built source. We are already running it through webpack and it'll build it again.
|
Looks great, thanks, I needed to do this soon but this helps a lot. @kjbekkelund I may go ahead and merge this so we can keep discussing solutions. |
|
Hi @jlongster, I amended my branch according to your remarks. |
|
@jlongster Absolutely — this should be merged! :) @geowarin No prob, my branch was just to get a discussion going on how to solve the devtools problem :) |
|
Ok I'll go ahead and merge it and look into it today. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add dev-tools to the basic example.
I hope this will help to fix #61.