0.0.10 breaks devtools

[idan]

I originally filed this issue on freeqaz/redux-simple-router-example#1. I am able to reproduce the behavior elsewhere by switching between 0.0.8 and 0.0.10, so maybe this is a more appropriate place to file the issue?

Gif for your viewing pleasure:

The only change I see to the state as reported by devtools is the addition of changeId.

[jlongster]

The gif (which is awesome, really helps thanks) is showing 0.0.8. Are you sure that it worked in 0.0.8 and broke in 0.0.10? It's confusing that you aren't showing it breaking the latest version.

[idan]

Hmm, weird. I definitely recorded it with the latest version, which included changeId in the state. Maybe I didn't properly blow away my node_modules? Will retry.

[idan]

From the other issue, here's screenshots of the state for each version:

Here's devtools' picture of the state changes in 0.0.8:

And here's the same thing for 0.0.10:

[jlongster]

Oh, you are right. I think I was looking at the action but thinking that was state. In previous versions we actually stored the avoidRouterUpdate flag in the state.

I'll take a look soon.

[rgdelato]

Glad to see that someone else reported this! I came in to report the same issue, except that I don't know how to make cool animated GIFs, so I maybe wouldn't have been as helpful.

(P.S. What are you using to make your animated GIFs?)

[idan]

@rdelatorre I use cloudapp, but there are a number off free options out there along the power/simplicity curve:

• Licecap
• Recordit
• quicktime->ffmpeg flavor 1
• quicktime->ffmpeg flavor 2

[fkrauthan]

I have the same issue with my project. I started right away with the latest version but the ReduxDevTool events have no influence on my visible application state.

[fkrauthan]

The problem is the history listen dispatching of event. You set avoidRouterUpdate to true which results in not counting up the change id. So lastChangeId is always gonna be equal to changeId so you never update the route when the store changes.

[jlongster]

@kjbekkelund Have you tried it with devtools yet? I will very soon but work has just been crazy. I'll add the devtools to the basic example which will help have a quick simple project to diagnose issues.

[geowarin]

As @fkrauthan says, incrementing the changeId systematically does fix the problem.
However, it also breaks a bunch of tests.

My guess is https://github.com/jlongster/redux-simple-router/blob/master/src/index.js#L95 will stop redux from replaying the changes when going back in time.

[fkrauthan]

Don't we just need a flag outside of the two listeners that gets used to prevent a router change triggering a endless loop instead of relaying on that id?

[kimjoar]

@jlongster Haven't had time to play with devtools yet. Will try to get some time to do it soon.

[idan]

❤️ ✨ Thank you!