React 15.0.1 #512
Merged
React 15.0.1 #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were deprecated in React v0.14 and have now been removed. react-rails no longer needs these fallbacks in place.
|
It would be nice if this got merged |
|
+1 |
|
Sorry for the delay! Thanks for bumping it. Emoji responses are great but they don't trigger a notification ... I wonder if there's a setting for that. Anyways, yeah, I think the previous React deprecations are enough for our case! |
|
We run in to this issue, facebook/react#6547 our select with optgroup stopped working. I guess it will be fixed in next point release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React v15.0 and React v15.0.1 were released last week. It'd be awesome to get react-rails onto v15.0.1 as well.
Two things to note that I wasn't quite sure about:
cloneWithPropsaddon has been removed. In this PR, I have removed it fromlib/assets/react-source/development,lib/assets/react-source/production, andreact-builds/. Should we have done deprecation warnings on the gem side of things or were the React warnings sufficient? I believe React warnings were sufficient but figured I'd double check.React.renderandReact.unmountComponentAtNodewere removed so I removed the fall backs to those in thereact_ujs_mount. I grepped and didn't see any other references to removed deprecations. I'm not quite sure why we needed to have those fallbacks when the gem had React v0.14 so I figured I'd double check that it was okay to remove them.Thanks for all the work you put into this gem. Let me know if theres anything I should change about this PR!