react-rails 2.0

[rmosolgo]

There are some issues building up, I think they will need some breaking changes. Here's what's on my list. Do you have anything else that's missing?

• Support Rails 5.0
  • Fix before_filter usage in ControllerLifecycle Depreciation warnings with Rails 5 #404
  • Fix messed up server rendering flow
• Support Sprockets 3
  • Figure out cases where assets aren't transformed (Asset pipeline require not working with coffeescript [v1.4.2 and above] #415, Loading .js.jsx files doesn't work in specs anymore #431)
  • Support precompiled assets (Server-side rendering is not working with sprockets-rails 3.0 #443, PR:
    Fix(SprocketsRenderer) support Sprockets::Manifest if assets were precompiled #430)
• Support Sprockets 4 ?
• Support Turbolinks 5
  • Stop warning about Turbolinks 2.2.4
  • Update for new Turbolinks API
  • Split UJS into different files, make react_ujs a manifest?
• Reduce Rails dependency
  • Altogether here: Minimize rails dependency #558
  • Basically, just merge this: Only require rails as a development dependency #427
  • Don't depend on sprockets Register with sprockets when sprockets is available #493
• Improve the flexibility of React addons
• use webpacker
• Support custom ReactJS builds (backed with npm & webpack, built into the apps asset directory)
• Expose renderToString etc without //= require react-server (Render static html client-side #442)
• General cleanup
  • Use .js files for CONSOLE_POLYFILL and CONSOLE_REPLAY
  • Can we merge engine.rb and railtie.rb? They're almost the same thing, right?
  • Fix replay_console + server rendering prerendering warning  #555
• Support require() environments refactor(UJS) make it webpack-friendly #678
• Expose UJS
• Document custom component-fetching function
• Improve documentation
  • [ ] Improve YARD docs
  • [ ] Split readme into guides & improve content
  • Update readme

[twe4ked]

Thanks for creating this issue @rmosolgo. Looks like #450 could be a dot-point under Support Rails 5.0.

Edit: Just realised #450 is a duplicate of #404. Sorry.

[rmosolgo]

Thanks, I added a note!

[SylarRuby]

I've just seen this list for version 2. Ok, support for rails 5 as I'm getting this: #467

[connorshea]

Do you mean Sprockets 3 or Sprockets 4? At the moment I'm testing Turbolinks 5 and Sprockets 4.0.0.beta2 and react-rails isn't playing well with one or both of them.

[rmosolgo]

Oh, I didn't know Sprockets 4 was so close to launching! Will it be part of Rails 5?

I expect Turbolinks 5 to be supported in the latest (1.6.2). Please open an issue if you have any trouble!

[connorshea]

@rmosolgo Upgrading from 3.x and 4.x: https://github.com/rails/sprockets/blob/master/UPGRADING.md

I don't think it'll be apart of Rails 5, at least not as far as I know.

[connorshea]

@rmosolgo and thank you very very much for maintaining the gem for so long and so well! I was so happy to see react-rails had already been upgraded to support Rails 5, most other gems were throwing deprecations warnings right and left.

[connorshea]

@rmosolgo update: It looks like this was entirely a Turbolinks 5 problem. Since Turbolinks 5 has no guide for updating, I didn't realize the events had changed, so all our JavaScript stopped loading.

Using Turbolinks Classic and Sprockets 5.0.0 works fine with react-rails, apologies!

[connorshea]

@rmosolgo you can probably remove the renderToString TODO, React v15.0 will remove it.

[rmosolgo]

They're still on ReactDOMServer though, right? I think we still need them somehow, that's how we implement server-side rendering!

For my part, I need renderToString in the browser for integrating with some other libraries, so I'd like to have a nice way to get it from react-rails!

[connorshea]

Not sure, I guess you'd have to test 15.0-rc1 to see what happens.

[drush]

Is React 15.0 support implicit for this issue, or should it be added to the checklist? Don't see a 15.0 ticket elsewhere.

[rmosolgo]

@drush React 15 was merged in #512 and just shipped in 1.7.0 :)