Fix NPE for null failed processor in IdentityFlowProcessorVerification #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarnokd
approved these changes
Feb 21, 2018
|
LGTM, thanks James! |
viktorklang
approved these changes
Feb 21, 2018
|
@reactive-streams/contributors Merging this. |
|
@jroper You'll need to rebase this and add yourself to the CopyrightWaivers.txt in this PR. |
Fixes reactive-streams#425 IdentityFlowProcessorVerification.createFailedProcessor is allowed to return null, but the TCK throws an NPE if it does. This introduces a null check to ensure that doesn't happen.
jroper
force-pushed
the
flow-processor-verification-failed
branch
from
0e3d797
to
264b60c
Compare
|
@viktorklang Done. |
|
@reactive-streams/contributors merging. Thanks @jroper! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #425
IdentityFlowProcessorVerification.createFailedProcessor is allowed to return null, but the TCK throws an NPE if it does. This introduces a null check to ensure that doesn't happen.