Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IdentityFlowProcessorVerification throws NPE when createFailedFlowPublisher returns null #425

Closed
jroper opened this issue Feb 21, 2018 · 0 comments
Closed

IdentityFlowProcessorVerification throws NPE when createFailedFlowPublisher returns null #425

jroper opened this issue Feb 21, 2018 · 0 comments

Comments

@jroper
Copy link
Contributor

jroper commented Feb 21, 2018

IdentityFlowProcessorVerification.createFailedFlowPublisher is allowed to return null, but if you do return null, then an NPE will be thrown because it doesn't check if it's null before passing it to FlowAdapters.toPublisher.
jroper added a commit to jroper/reactive-streams-jvm that referenced this issue Feb 21, 2018
@jroper
Fix NPE for null failed processor in IdentityFlowProcessorVerification
0e3d797 
Fixes reactive-streams#425

IdentityFlowProcessorVerification.createFailedProcessor is allowed to
return null, but the TCK throws an NPE if it does. This introduces a
null check to ensure that doesn't happen.
@jroper jroper mentioned this issue Feb 21, 2018
Merged
jroper added a commit to jroper/reactive-streams-jvm that referenced this issue Mar 19, 2018
@jroper
Fix NPE for null failed processor in IdentityFlowProcessorVerification
264b60c 
Fixes reactive-streams#425

IdentityFlowProcessorVerification.createFailedProcessor is allowed to
return null, but the TCK throws an NPE if it does. This introduces a
null check to ensure that doesn't happen.
viktorklang pushed a commit that referenced this issue Mar 20, 2018
@jroper @viktorklang
Fix NPE for null failed processor in IdentityFlowProcessorVerification
582fdae 
Fixes #425

IdentityFlowProcessorVerification.createFailedProcessor is allowed to
return null, but the TCK throws an NPE if it does. This introduces a
null check to ensure that doesn't happen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jroper