Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pylint issues #937

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Fix pylint issues #937

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eeea87a
Fix pylint issues
Archmonger Feb 23, 2023
ebc785e
Add fixme
Archmonger Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/idom/html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,7 @@
)


@custom_vdom_constructor
def _(
def _fragment(
attributes: VdomAttributes,
children: Sequence[VdomChild],
key: Key | None,
Expand All @@ -299,6 +298,10 @@ def _(
return model


# FIXME: https://github.com/PyCQA/pylint/issues/5784
_ = custom_vdom_constructor(_fragment)


# Dcument metadata
base = make_vdom_constructor("base")
head = make_vdom_constructor("head")
Expand Down Expand Up @@ -394,8 +397,7 @@ def _(
noscript = make_vdom_constructor("noscript")


@custom_vdom_constructor
def script(
def _script(
attributes: VdomAttributes,
children: Sequence[VdomChild],
key: Key | None,
Expand Down Expand Up @@ -440,6 +442,9 @@ def script(
return model


# FIXME: https://github.com/PyCQA/pylint/issues/5784
script = custom_vdom_constructor(_script)

# Demarcating edits
del_ = make_vdom_constructor("del")
ins = make_vdom_constructor("ins")
Expand Down