Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pylint issues #937

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Fix pylint issues #937

merged 2 commits into from
Feb 23, 2023

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Feb 23, 2023

See this link for details.

Checklist

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog.rst has been updated with any significant changes.
  • GitHub Issues which may be closed by this Pull Request have been linked.

@Archmonger Archmonger marked this pull request as ready for review February 23, 2023 05:16
@Archmonger Archmonger requested a review from rmorshea February 23, 2023 05:16
@rmorshea
Copy link
Collaborator

rmorshea commented Feb 23, 2023

It looks like there may actually be a way to work around this: pylint-dev/pylint#2926

[tool.pylint.typecheck]
signature-mutators = ["idom.core.vdom.custom_vdom_constructor"]

@Archmonger
Copy link
Contributor Author

This would for internally for our own test suite, but our pyproject.toml isn't distributed within our pypi package. We could add it (or a .pylintrc) to our distribution, but that's a bit weird.

@rmorshea
Copy link
Collaborator

Can you add a comment about why we do this with a link to the GitHub issue?

@rmorshea
Copy link
Collaborator

I'm contemplating making a contribution that would allow us to achieve this with a comment. It seems kind of annoying to have to dirty up our code because of this.

@Archmonger
Copy link
Contributor Author

I don't know if that's technologically possible within PyLint's stack. It likely would require us to go down the rabbit hole of fixing pylint-dev/pylint#5784

@rmorshea
Copy link
Collaborator

I think I did it: pylint-dev/pylint#8332

@rmorshea rmorshea merged commit b8eeaa9 into reactive-python:main Feb 23, 2023
@Archmonger Archmonger deleted the fix-pylint branch February 23, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants