Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unmount #901

Merged
merged 4 commits into from
Feb 1, 2023
Merged

Fix unmount #901

merged 4 commits into from
Feb 1, 2023

Conversation

rmorshea
Copy link
Collaborator

@rmorshea rmorshea commented Feb 1, 2023

closes: #896

Ignore the white space changes due to latest version of black

Checklist

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog.rst has been updated with any significant changes.
  • GitHub Issues which may be closed by this Pull Request have been linked.

@rmorshea rmorshea marked this pull request as ready for review February 1, 2023 04:16
@rmorshea
Copy link
Collaborator Author

rmorshea commented Feb 1, 2023

Will reopen #760 on merge

@rmorshea rmorshea requested a review from Archmonger February 1, 2023 04:34
@rmorshea rmorshea merged commit 491c05a into main Feb 1, 2023
@rmorshea rmorshea deleted the fix-unmount branch February 1, 2023 07:31
@@ -23,7 +23,13 @@ more info, see the :ref:`Contributor Guide <Creating a Changelog Entry>`.
Unreleased
----------

No changes.
**Reverted**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized we're using a non-standard Keep-A-Changelog category here. Not a big deal though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stale event handlers can reside in the client
2 participants