no need to unmount on reconnect #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmorshea
force-pushed
the
no-unmoun-on-reconnect
branch
from
af0612d to
e9a0fb3
Compare
|
I think a consequence of this change is that now stale event handlers can stay within the client. This exception occurs if I restart the webserver while keeping an IDOM tab open: |
|
yup, that sounds right |
|
I don't think this is an intended though, since it silently breaks all event handlers on reconnect. Can we potentially refresh all handlers within the client on reconnect? |
|
oh, i was agreeing that it sounds like a bug. |
rmorshea
added a commit
that referenced
this pull request
Feb 1, 2023
rmorshea
added a commit
that referenced
this pull request
Feb 1, 2023
* remove upper bound * revert #886 + add test + misc * changelog entry * changes for latest black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #760
I was unable to get preact working with the new React
createRootAPI. We can handle that in a follow-up issue. This narrowly focuses on removing an unnecessary unmount call on reconnect.Checklist
Please update this checklist as you complete each item:
changelog.rsthas been updated with any significant changes.