Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix append to stale children ref #807

Merged
merged 1 commit into from
Sep 12, 2022
Merged

fix append to stale children ref #807

merged 1 commit into from
Sep 12, 2022

Conversation

rmorshea
Copy link
Collaborator

@rmorshea rmorshea commented Sep 11, 2022

Closes: #806

A recent change to how components render saved a new list of children to the parent component. In doing so, this caused references to the old list held in other parts of the layout logic to become stale. The solution is to avoid holding onto a reference to a model's children.

Checklist

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog.rst has been updated with any significant changes.
  • GitHub Issues which may be closed by this Pull Request have been linked.

Copy link
Contributor

@Archmonger Archmonger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmorshea rmorshea merged commit d682407 into main Sep 12, 2022
@rmorshea rmorshea deleted the fix-806 branch September 12, 2022 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VDOM cannot be rendered after a component
2 participants