Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VDOM cannot be rendered after a component #806

Closed
Archmonger opened this issue Sep 9, 2022 · 2 comments · Fixed by #807
Closed

VDOM cannot be rendered after a component #806

Archmonger opened this issue Sep 9, 2022 · 2 comments · Fixed by #807
Labels
priority-0-critical Must be resolved and released immediately. type-bug About something that isn't working
Milestone

Comments

@Archmonger
Copy link
Contributor

Archmonger commented Sep 9, 2022

Current Situation

v0.40.0 brought a regression where VDOM elements cannot be rendered following a component.

For example, Text 2 is never rendered in the following scenario:

from idom import component, html, run


@component
def Test():
    return html.div("Hello World!")


@component
def App():
    return html.div(
        html.h1("Text 1"),
        Test(),
        html.h1("Text 2"),
    )

run(App)

Proposed Actions

This is a pretty major breaking bug, and needs to be resolved ASAP.

I personally would also yank the v0.40.0 release as it has been roughly a month of unusably broken behavior.

@Archmonger Archmonger added type-bug About something that isn't working priority-0-critical Must be resolved and released immediately. labels Sep 9, 2022
@Archmonger Archmonger added this to the 1.0 milestone Sep 9, 2022
@rmorshea
Copy link
Collaborator

rmorshea commented Sep 9, 2022

I've got an idea on how to bypass the issues with JSON patch. Will try to get to this over the weekend.

@rmorshea
Copy link
Collaborator

rmorshea commented Sep 9, 2022

Version has also been yanked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-0-critical Must be resolved and released immediately. type-bug About something that isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants