Remove reliance on CamelCase component names

[Archmonger]

is_component_def now checks if a function is decorated with @idom.component to determine whether something is a component.

This implementation also works if directly using @component as a decorator.

Also, all hook names are now explicitly checked for rather than assuming everything use_* is a hook.

[Archmonger]

Accidentally PR'd the archived repo. Moving to idom-team/flake8-idom#3

[rmorshea]

I unarchived this a while back. Haven't had time to switch to flake8-idom.

[rmorshea]

A note on this this - one reason using the CamelCase for function component definitions makes sense is that the behavior is much more like that of a class. If for example, we named these with snake case one might expect the following to be true:

@component
def my_component():
    print("It ran!")
    return idom.html.div()

assert my_component() == idom.html.div()

However, in reality:

assert isinstance(my_component(), Component)

We also do not see the print statement.

To get the initially expected result we must do manually, what the layout automatically would otherwise:

instance = my_component()
assert instance.render() == idom.html.div()

STDOUT:

It ran!

The take away here being that the naming of function components with CamelCase is more than just stylistic. It is an attempt to indicate a behavioral difference between functions that are/aren't components - functions named with CamelCase behave much more like a class (i.e. it's an object constructor).

[Archmonger]

To end users, that's irrelevant.

Functions def = snake_case
Class def = CamelCase

Regardless of what they mutate into due to the decorator, I believe PEP8 should be followed.

Plus we can't expect most users to use the flake8-idom package. Many will just use a pylint-only configuration.

[rmorshea]

You'll need to update the test cases in this file to use an @component decorator for the tests to pass: https://github.com/idom-team/flake8-idom-hooks/blob/main/tests/hook_usage_test_cases.py

[rmorshea]

LGTM besides this. Will merge and release next week.

[rmorshea]

closed in favor of #14