Remove reliance on camel case #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmorshea
force-pushed
the
remove-reliance-on-CamelCase
branch
from
feefba9 to
e816dde
Compare
|
Using regex to get that idom.component.component case seems a bit overkill imo. I'm okay with it though. You might want to add a test for it if you're complicating things just for that accomodation. 👎 to force pushing a remote branch though 🥺 |
|
did i do that again? this is a new PR |
|
Yep |
|
Ohhh I see it is a new PR. Didn't pay close enough attention while reading on mobile. |
Archmonger
approved these changes
Aug 24, 2022
rmorshea
force-pushed
the
remove-reliance-on-CamelCase
branch
4 times, most recently
from
a964dd2 to
79408d8
Compare
rmorshea
force-pushed
the
remove-reliance-on-CamelCase
branch
from
79408d8 to
64b7b17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #9 with minor improvements