1762 + Meteor 1.4.2.7 #1855
Merged
1762 + Meteor 1.4.2.7 #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 16, 2017 00:30
- Meteor 1.4.2.7 - updated dependencies - updated yarn.lock
- Resolves #1762 - Removes transliteration.min.js (import direct) - special case handling on PDP handle update
Updated to use alternate minifier abernix:standard-minifier-js See Meteor Issue 8378
aaronjudd
requested review from
jshimko
and removed request for
brent-hoover
jshimko
approved these changes
Feb 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing:
1.4.2.7:
running the app normally -> no issue should be caused by 1.4.2.7, but pay attention to module loading.
For transliteration:
Login in as admin, change your language to Chinese, Hebrew etc..
Save products handle, check that route name has been transliterated AND slugified..
Test with routes, by updating shop name, refresh, check routes, like pdp, are using a new transliterated, slugified route.