You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Where ever getSlug is implemented, in browser and server we should be able to use slugify from transliteration as an import:
import { transliterate as tr, slugify } from "transliteration";
This works server side, but the functions do not work client side.
As a temporary solution to this, we included /client/lib/transliteration.min.js. The goal of this issue is to remove the min.js, and get the imports to work. As is, the import works, but the (tr, slugify) functions do not. As a quick attempt to test this again did not work, this might need some src debugging. It's not ideal to change the transliteration package, as this is the only one that supports some of our Asian languages. Acceptance is that getSlug works everywhere (if it breaks, so will routing).
This might be what causes routing issues #1334 where the prefix doesn't always load and then a 404 is display. This can happen if getSlug doesn't return a value, so if transliteration isn't loaded, we see this issue.
The text was updated successfully, but these errors were encountered:
Where ever
getSlug
is implemented, in browser and server we should be able to useslugify
from transliteration as an import:This works server side, but the functions do not work client side.
As a temporary solution to this, we included
/client/lib/transliteration.min.js
. The goal of this issue is to remove the min.js, and get the imports to work. As is, the import works, but the (tr, slugify) functions do not. As a quick attempt to test this again did not work, this might need some src debugging. It's not ideal to change the transliteration package, as this is the only one that supports some of our Asian languages. Acceptance is that getSlug works everywhere (if it breaks, so will routing).This might be what causes routing issues #1334 where the prefix doesn't always load and then a 404 is display. This can happen if getSlug doesn't return a value, so if transliteration isn't loaded, we see this issue.
The text was updated successfully, but these errors were encountered: