This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
fix:didFocus event can't be triggered due to component update and red… #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ux middleware execution timing[react-navigation#53]
Ashoat
reviewed
Sep 5, 2018
| @@ -43,7 +43,9 @@ function reduxifyNavigator<State: NavigationState, Props: RequiredProps<State>>( | |||
| } | |||
|
|
|||
| componentDidUpdate() { | |||
| didUpdateCallback(); | |||
| setTimeout(() => { | |||
| didUpdateCallback(); | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Ashoat
suggested changes
Sep 5, 2018
There was a problem hiding this comment.
Before I can consider merging this PR, I’ll need to be able to reproduce the issue you describe, so that I can verify this is the best fix for it.
Can you please create an Expo Snack that reproduces this issue? Please include only the minimal code necessary to reproduce it. If you can’t reproduce the issue in an Expo Snack, you can try using react-native init to create a new empty project and see if you can reproduce the issue there.
mnzaki
added a commit
to jolocom/smartwallet-app
that referenced
this pull request
Jul 15, 2019
infinitered/ignite-andross#277 moaazsidat/react-native-qrcode-scanner#161 moaazsidat/react-native-qrcode-scanner#177 moaazsidat/react-native-qrcode-scanner#136 react-native-camera/react-native-camera#1797 react-native-camera/react-native-camera#1686 react-native-camera/react-native-camera#1686 react-navigation/redux-helpers#87 react-navigation/redux-helpers#60 react-navigation/redux-helpers#53 https://www.youtube.com/watch?v=CnQ8N1KacJc Fixes #1326 The navigation actions were turned into ThunkActions and now directly call react-navigation's navigator.dispatch, which handles state internally Usages of the navigationActions were fixed Also QRcodeScanner was cleaned up a bit and hacked to properly re-enable the camera by re-rendering it (so it gets remounted). Now camera works again if you press back after scanning a QR code.
|
shyaniv7/react-navigation@2059422 mentioned in react-navigation/react-navigation#4670 (comment) works for me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ux middleware execution timing[#53]
I found that
didUpdateCallback(in ReduxifyNavigator - componentDidUpdate) will be executed before redux middleware handler, which meansDelayedSubscriberwill be triggered before being added.