Don't manually store react-navigation state #1326
Labels
Comments
|
It was even setup right and events weren't being handled by the custom reducers, because it was never combined into the root reducer.... #1361 |
mnzaki
added a commit
that referenced
this issue
Jul 15, 2019
infinitered/ignite-andross#277 moaazsidat/react-native-qrcode-scanner#161 moaazsidat/react-native-qrcode-scanner#177 moaazsidat/react-native-qrcode-scanner#136 react-native-camera/react-native-camera#1797 react-native-camera/react-native-camera#1686 react-native-camera/react-native-camera#1686 react-navigation/redux-helpers#87 react-navigation/redux-helpers#60 react-navigation/redux-helpers#53 https://www.youtube.com/watch?v=CnQ8N1KacJc Fixes #1326 The navigation actions were turned into ThunkActions and now directly call react-navigation's navigator.dispatch, which handles state internally Usages of the navigationActions were fixed Also QRcodeScanner was cleaned up a bit and hacked to properly re-enable the camera by re-rendering it (so it gets remounted). Now camera works again if you press back after scanning a QR code.
|
Closed by #1374 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Currently we manually store
react-navigationstate in redux, which is not recommended and is not really useful.Instead we should be using
navigator.dispatchfor dispatching navigation actions, following this guideWe should also get rid of the
react-navigation-redux-helperspackage, which would become useless.This is somewhat related to #1325
The text was updated successfully, but these errors were encountered: