Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

0.57.2 Discussion #46

Closed
kelset opened this issue Oct 5, 2018 · 29 comments
Closed

0.57.2 Discussion #46

kelset opened this issue Oct 5, 2018 · 29 comments
Labels
backport request Cherry picking a change into an existing release stable Stable version

Comments

@kelset
Copy link
Member

kelset commented Oct 5, 2018

Conversation on this thread are limited to 0.57.2 release's major issues and backport (cherry-pick) requests from commits that are already on master - so that we can then produce a 0.57.3 release in the near future.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.57.1 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

@kelset kelset added stable Stable version backport request Cherry picking a change into an existing release labels Oct 5, 2018
@kelset
Copy link
Member Author

kelset commented Oct 5, 2018

Current situation:

@ChrisEdson

This comment has been minimized.

@cristeahub

This comment has been minimized.

@kelset
Copy link
Member Author

kelset commented Oct 5, 2018

@ChrisEdson, @cristeahub thanks for the feedback on that but please let's try to keep the conv around commits and cherry picks ;)

(the reason why my comment describes the situation is because I want to tunnel people that may end up in this issue to those links instead of writing stuff here ;D )

@ikesyo
Copy link

ikesyo commented Oct 5, 2018

I want the following to be cherry-picked:

@radeno
Copy link

radeno commented Oct 8, 2018

@kelset
Copy link
Member Author

kelset commented Oct 8, 2018

Thanks @radeno for the suggestions! Regarding FBJS I'd prefer to avoid it because it's not directly fixing anything AFAIK (and that package itself is, by self admission, not directly for OSS).

A few more commits I want to see cherry picked:

@radeno
Copy link

radeno commented Oct 8, 2018

@kelset you are right about FBJS.

I don't like fix to http/https protocol. (facebook/react-native@d00bdb9) It is Android specific, but fix code appears on React Native side, not Android side. That commit smells.

Android have from API v16 (which is minimal SDK for 0.57 right?) normalization method: https://developer.android.com/reference/android/net/Uri.html#normalizeScheme()
Need change one line https://github.com/facebook/react-native/blob/1151c096dab17e5d9a6ac05b61aacecd4305f3db/ReactAndroid/src/main/java/com/facebook/react/modules/intent/IntentModule.java#L82 Maybe it is time for my first PR

Update:
PR open: facebook/react-native#21561

@kelset
Copy link
Member Author

kelset commented Oct 8, 2018

Yeah I agree with your assessment @radeno, go for it 👍

@fungilation
Copy link

I don't claim to know the internal release workings of React, but is it wise for RN to be often syncing with their alpha versions? 16.6.0-alpha.400d197 in @kelset's linked PR.

@kelset
Copy link
Member Author

kelset commented Oct 8, 2018

I share your concern of moving to an alpha dep, but considering that most likely there won't be another sync commit until after ReactConf (Oct 25th) IF testing goes well I'd prefer to allow people to be able to a update to a version of RN that allows them to use 16.5.2 (which is currently not the case).

And we are not often using alpha versions.

@elicwhite
Copy link
Contributor

I'd like to get this commit picked to add a deprecation warning to ListView: facebook/react-native@e90f5fa

@radeno
Copy link

radeno commented Oct 10, 2018

Another fixes:

@kelset
Copy link
Member Author

kelset commented Oct 10, 2018

thanks for the links! I'm just waiting for this to land facebook/react-native#21570 (which I think it's simply a matter of some automated process to complete) and I'll proceed to cherry pick & test 💪

@radeno

This comment has been minimized.

@kelset
Copy link
Member Author

kelset commented Oct 10, 2018

Yes, it's OT for this issue so I've opened via GitHub a dedicated issue, see #47 - we can discuss about it there.

@radeno
Copy link

radeno commented Oct 11, 2018

@grabbou
Copy link
Member

grabbou commented Oct 11, 2018

Going to cherry-pick them later in the afternoon. Will be updating this thread shortly.

@elicwhite
Copy link
Contributor

Let’s include the deprecation warning for ListView as well.
facebook/react-native@e90f5fa

@jeveloper
Copy link

@kelset Lorenzo , do i understand correctly, 57.3 will not have a fix for google build tools 3.2 or it will?

Thank you

@radeno
Copy link

radeno commented Oct 11, 2018

@jeveloper even 0.58 doesn't have any support about new building system. It is still in progress facebook/react-native#21628
facebook/react-native#21632

@matthargett
Copy link

let's get these safe deprecation/warning commits in, as discussed on Slack:

@elicwhite
Copy link
Contributor

@matthargett, two of those commits were listed by other people earlier up. The third one doesn't seem relevant it is changing an RNTester file. Did you mean to link to something else instead?

@grabbou
Copy link
Member

grabbou commented Oct 11, 2018

All commits from this comment, this and this one have been cherry-picked.

Note: In order to cherry-pick Fix InterpolatorType crash on Android, I had to cherry-pick facebook/react-native@0df8e7d, facebook/react-native@69a51da and facebook/react-native@677f1de.

@grabbou grabbou closed this as completed Oct 11, 2018
@kelset
Copy link
Member Author

kelset commented Oct 12, 2018

(reopening temporarily until I fix the release of 0.57.3)

@kelset kelset reopened this Oct 12, 2018
@radeno
Copy link

radeno commented Oct 12, 2018

@kelset these two commits missing:
first: facebook/react-native@d00bdb9 and then: facebook/react-native@4b6f02e
second is fix for first commit.

don't you want it in 0.57.3?

@kelset
Copy link
Member Author

kelset commented Oct 12, 2018

@jeveloper there is already a workaround in 0.57.2 (so the version of RN currently available should be able to work with Android Studio 3.2) -> facebook/react-native@a4fed6e

@radeno I didn't do the actual cherry-pick for release yesterday, probably it was overlooked. I'm fixing some CI issues atm, once everything is green again I'll try to get those in too.

@kelset
Copy link
Member Author

kelset commented Oct 12, 2018

Ok, 0.57.3 is out. Headsup, you need to update react and test-renderer to "16.6.0-alpha.8af6728" to have it work.

@kelset kelset closed this as completed Oct 12, 2018
@react-native-community react-native-community locked as resolved and limited conversation to collaborators Oct 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport request Cherry picking a change into an existing release stable Stable version
Projects
None yet
Development

No branches or pull requests

10 participants