bump Android NDK to r17c #21628
Closed
bump Android NDK to r17c #21628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
gengjiawen
suggested changes
Oct 10, 2018
There was a problem hiding this comment.
You missed the docker config in https://github.com/facebook/react-native/blob/master/ContainerShip/Dockerfile.android-base
|
@gengjiawen thank you 👍 |
gengjiawen
approved these changes
Oct 11, 2018
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Oct 12, 2018
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@dulmandakh merged commit 436cf15 into |
kelset
pushed a commit
that referenced
this pull request
Oct 12, 2018
Summary: bump Android NDK to r17c, which is only available revision to download for r17. And it includes bug fixes. Pull Request resolved: #21628 Differential Revision: D10352162 Pulled By: hramos fbshipit-source-id: d372e55443260242a44a1f73698977a3e361f001
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: bump Android NDK to r17c, which is only available revision to download for r17. And it includes bug fixes. Pull Request resolved: facebook#21628 Differential Revision: D10352162 Pulled By: hramos fbshipit-source-id: d372e55443260242a44a1f73698977a3e361f001
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump Android NDK to r17c, which is only available revision to download for r17. And it includes bug fixes.
Test Plan:
CI is green