bump Android SDK to 28 #21632
bump Android SDK to 28 #21632
Conversation
facebook-github-bot
added
the
CLA Signed
|
bumped Gradle to 4.10.2 because gradle-download-task landed tests for it. Also bumped android plugin to 3.2.1. |
|
@hramos bumped tools, but keeping target SDK. |
There was a problem hiding this comment.
@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This was blocked for a while, as upgrading the Gradle binary internally takes some manual work. The problem I'm running into now is that while Android SDK 28 is available in our internal repository, we do not yet have access to Build Tools 28.0.3. The latest version we have is 28.0.2, but Gradle 4.10.2's minimum supported version is 28.0.3. |
|
This is landing now. As build tools 28.0.3 are not available on our internal build servers yet, I had to downgrade the gradle plugin as 3.2.1 requires 28.0.3. The combination I landed on is compileSdkVersion to 28, buildToolsVersion to 28.0.2, Gradle to 4.7, and Android Gradle plugin to 3.2.0. |
|
@dulmandakh merged commit 9d00d4d into |
…Plugin to 3.2.0 (#21632) Summary: This PR is bumping compileSdkVersion to 28, buildToolsVersion to 28.0.2, Gradle to 4.7, Android Gradle plugin to 3.2.0. Gradle 4.7 added support for Java 10 and 11. allow-large-files Release Notes: -------------- [ANDROID] [ENHANCEMENT] [SDK] - bump to 28 Pull Request resolved: #21632 Reviewed By: mdvacca Differential Revision: D13084836 Pulled By: hramos fbshipit-source-id: e0f493881e80e87faf8c3ef1ac77044495966a49
|
Build tools 28.0.3 are now available internally. I have a diff out that will update us to 28.0.3, as well as Gradle 4.10.2 and Gradle Plugin 3.2.1. |
|
f3e5cce bumped gradle to 4.10.2 and remove build tools version. Now only need to bump gradle android plugin. |
|
That commit bumped the Gradle version used in OSS to 4.10.2, but our internal Gradle tests were still on 4.7 and therefore failing internally. |
…Plugin to 3.2.0 (facebook#21632) Summary: This PR is bumping compileSdkVersion to 28, buildToolsVersion to 28.0.2, Gradle to 4.7, Android Gradle plugin to 3.2.0. Gradle 4.7 added support for Java 10 and 11. allow-large-files Release Notes: -------------- [ANDROID] [ENHANCEMENT] [SDK] - bump to 28 Pull Request resolved: facebook#21632 Reviewed By: mdvacca Differential Revision: D13084836 Pulled By: hramos fbshipit-source-id: e0f493881e80e87faf8c3ef1ac77044495966a49
…Plugin to 3.2.0 (#21632) Summary: This PR is bumping compileSdkVersion to 28, buildToolsVersion to 28.0.2, Gradle to 4.7, Android Gradle plugin to 3.2.0. Gradle 4.7 added support for Java 10 and 11. allow-large-files Release Notes: -------------- [ANDROID] [ENHANCEMENT] [SDK] - bump to 28 Pull Request resolved: facebook/react-native#21632 Reviewed By: mdvacca Differential Revision: D13084836 Pulled By: hramos fbshipit-source-id: e0f493881e80e87faf8c3ef1ac77044495966a49
This PR is bumping compileSdkVersion to 28, buildToolsVersion to 28.0.3, Gradle to 4.10.2, Android Gradle plugin to 3.2.1.
Gradle 4.7 added support for Java 10 and 11.
Test Plan:
CI is green, and RNTester app is working as expected.
Release Notes:
[ANDROID] [ENHANCEMENT] [SDK] - bump to 28