fix: Drop @react-native/metro-config dep for RN 0.72 config fallback #1899
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| import type {InputConfigT} from 'metro-config'; | ||
| import path from 'path'; | ||
| import type {ConfigLoadingContext} from './loadMetroConfig'; | ||
|
|
||
| /** | ||
| * This module reproduces defaults from the @react-native/metro-config package, | ||
| * used in ./loadMetroConfig.js to provide a soft upgrade process when upgrading | ||
| * to React Native 0.72. | ||
| * | ||
| * These values will be used when: | ||
| * - RN CLI 11.x or greater is present in a project (from React Native 0.72). | ||
| * - The project has not yet followed the upgrade instructions to update | ||
| * metro.config.js to extend '@react-native/metro-config'. | ||
| * | ||
| * Until we remove this file in a future release, updates should be made both | ||
| * here and in '@react-native/metro-config'. (Note: Updates to these values are | ||
| * generally rare.) | ||
| * | ||
| * TODO(@huntie): Remove this file in a future React Native release. | ||
| */ | ||
|
|
||
| /** | ||
| * @deprecated (React Native 0.72.0) Defaults should be updated here and in | ||
| * https://github.com/facebook/react-native/tree/main/package/metro-config/index.js | ||
| */ | ||
| const INTERNAL_CALLSITES_REGEX = new RegExp( | ||
| [ | ||
| '/Libraries/Renderer/implementations/.+\\.js$', | ||
| '/Libraries/BatchedBridge/MessageQueue\\.js$', | ||
| '/Libraries/YellowBox/.+\\.js$', | ||
| '/Libraries/LogBox/.+\\.js$', | ||
| '/Libraries/Core/Timers/.+\\.js$', | ||
| '/Libraries/WebSocket/.+\\.js$', | ||
| '/Libraries/vendor/.+\\.js$', | ||
| '/node_modules/react-devtools-core/.+\\.js$', | ||
| '/node_modules/react-refresh/.+\\.js$', | ||
| '/node_modules/scheduler/.+\\.js$', | ||
| '/node_modules/event-target-shim/.+\\.js$', | ||
| '/node_modules/invariant/.+\\.js$', | ||
| '/node_modules/react-native/index.js$', | ||
| '/metro-runtime/.+\\.js$', | ||
| '^\\[native code\\]$', | ||
| ].join('|'), | ||
| ); | ||
|
|
||
| /** | ||
| * Get the static Metro config defaults for a React Native project. | ||
| * | ||
| * @deprecated (React Native 0.72.0) Defaults should be updated here and in | ||
| * https://github.com/facebook/react-native/tree/main/package/metro-config/index.js | ||
| */ | ||
| export default function getDefaultMetroConfig( | ||
| ctx: ConfigLoadingContext, | ||
| ): InputConfigT { | ||
| return { | ||
| resolver: { | ||
| resolverMainFields: ['react-native', 'browser', 'main'], | ||
| unstable_conditionNames: ['require', 'react-native'], | ||
| }, | ||
| serializer: { | ||
| getPolyfills: () => | ||
| require(path.join(ctx.reactNativePath, 'rn-get-polyfills'))(), | ||
|
Comment on lines
+61
to
+62
There was a problem hiding this comment. Deviates from |
||
| }, | ||
| server: { | ||
| port: Number(process.env.RCT_METRO_PORT) || 8081, | ||
| }, | ||
| symbolicator: { | ||
| customizeFrame: (frame: {file?: string}) => { | ||
| const collapse = Boolean( | ||
| frame.file && INTERNAL_CALLSITES_REGEX.test(frame.file), | ||
| ); | ||
| return {collapse}; | ||
| }, | ||
| }, | ||
| transformer: { | ||
| allowOptionalDependencies: true, | ||
| assetRegistryPath: 'react-native/Libraries/Image/AssetRegistry', | ||
| asyncRequireModulePath: require.resolve( | ||
| 'metro-runtime/src/modules/asyncRequire', | ||
| ), | ||
| babelTransformerPath: require.resolve( | ||
| 'metro-react-native-babel-transformer', | ||
| ), | ||
| }, | ||
| watchFolders: [], | ||
| }; | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restored (https://github.com/react-native-community/cli/pull/1875/files#diff-8218c5d0d266cb441ba7888833fc1aa54be26645ad47cf87253183504904fdd9L17-L19).