fix: Drop @react-native/metro-config dep for RN 0.72 config fallback #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntie
force-pushed
the
drop-metro-config-dep
branch
from
8032e95 to
19a07b6
Compare
huntie
commented
Apr 4, 2023
Comment on lines
+17
to
+19
| "metro-react-native-babel-transformer": "0.76.0", | ||
| "metro-resolver": "0.76.0", | ||
| "metro-runtime": "0.76.0", |
There was a problem hiding this comment.
huntie
commented
Apr 4, 2023
Comment on lines
+61
to
+62
| getPolyfills: () => | ||
| require(path.join(ctx.reactNativePath, 'rn-get-polyfills'))(), |
There was a problem hiding this comment.
Deviates from @react-native/metro-config, which references the standalone package @react-native/js-polyfills (technically, this was/is the first circular dep edge case!). These are equivalent, but allows this repo to not reference the RN-hosted package (see removal in yarn.lock).
huntie
commented
Apr 4, 2023
Comment on lines
-2676
to
-2690
| "@react-native/js-polyfills@^0.73.0": | ||
| version "0.73.0" | ||
| resolved "https://registry.yarnpkg.com/@react-native/js-polyfills/-/js-polyfills-0.73.0.tgz#d1becae77740c705392122684a55b373e610ab63" | ||
| integrity sha512-3/+q+l86xvV8xjx29On9/Dn0eWjo5MHYuuALHqyOlQIs3vLk/rQB4rn4izObiurhH3utXxqVnbOk+TB9yJo4ng== | ||
|
|
||
| "@react-native/metro-config@^0.73.0": | ||
| version "0.73.0" | ||
| resolved "https://registry.yarnpkg.com/@react-native/metro-config/-/metro-config-0.73.0.tgz#7601d2f4ba2252a4e359f8fda21008daf5f31eb2" | ||
| integrity sha512-b+q8Ot6nxPE2PXEua20Q0vhXYpVtVjUaTX/hv+7mL5hLzKeIWq/bIxF04GLWT93BBjGSlL0xaZ7iGIQNN75Hog== | ||
| dependencies: | ||
| "@react-native/js-polyfills" "^0.73.0" | ||
| metro-config "0.76.0" | ||
| metro-react-native-babel-transformer "0.76.0" | ||
| metro-runtime "0.76.0" | ||
|
|
There was a problem hiding this comment.
All dependencies on packages published from facebook/react-native are dropped.
robhogan
approved these changes
Apr 6, 2023
thymikee
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
React Native Metro config → React Native repo (facebook/react-native#36502)
This is a follow up to #1896.
Unfortunately the most recent CLI release was auto-consumed in React Native's CI, exposing a blocker where we could not consume the (repo-)circular dependency
react-native→@react-native-community/cli-plugin-metro→@react-native/metro-config— I 100% jumped the gun on this setup(!).While this is now mitigated by the new CLI release process, and possible in practice, we're opting to remove this circular setup as it would introduce maintenance headaches while we are working across two repos.
Changelog: Internal
This is an architectural simplification targeting React Native
main(0.73). However it is also worth cherry picking this commit to RN CLI10.x(targeting RN 0.72), so that we can once again bump all local Metro dependencies here (and replicate those bumps in both11.xand10.x). cc @robhogan @cipolleschiOpen as #1901.
Changes
@react-native/metro-configdependency fromcli-plugin-metro.@react-native/metro-configdefault config withincli-plugin-metro(to be used in the fallback case only).Note: An alternative approach for this is
peerDependencies, but given the recent issues and how this might affect strict internal and open source CI, I'm opting for the absolutely bulletproof solution.Test Plan
(Repeats test plan instructions from #1896).
@react-native/metro-config)@react-native/metro-config)✅ Identical configs are produced
(With only path changes from
yarn link)