[android] Do not import a linked Android.mk file if the library is not specifying a libraryName #1626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Given a
react-native config
that has the following setup:(note that
libraryName
is missing), you should not import theandroidMkPath
as the file is not going to be present. It will cause a build failure at compile time.Test Plan:
I've tested this locally on my fork. Seems like there are no tests for this
.gradle
file so I'm unsure how to test this further.