Adapt template to new architecture autolinking on Android

[thymikee]

Summary

Provides necessary changes for the autolinking to work in new architecture on Android. Depends on react-native-community/cli#1603 and is subject to change.

Upgraded the RN CLI to v9.0.0-alpha.0 so that it's testable locally.

Changelog

[Android] [Changed] - Adapt template to new architecture autolinking on Android

Test Plan

CI

[pull-bot]

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Messages

📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message. CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 48db2a9

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,784,690	+0
android	hermes	armeabi-v7a	7,188,365	+0
android	hermes	x86	8,096,408	+0
android	hermes	x86_64	8,074,164	+0
android	jsc	arm64-v8a	9,657,443	+0
android	jsc	armeabi-v7a	8,429,980	+0
android	jsc	x86	9,609,959	+0
android	jsc	x86_64	10,204,643	+0

Base commit: 55133ea
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 55133ea
Branch: main

[thymikee]

react-native-community/cli#1603 is now merged and released in 9.0.0-alpha.0, so this PR is now unblocked and ready to be merged.

[cortinico]

react-native-community/cli#1603 is now merged and released in 9.0.0-alpha.0, so this PR is now unblocked and ready to be merged.

Awesome, thanks for the heads up 👍
I'll import this and get back to you with some testing.

[facebook-github-bot]

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cortinico]

This is currently blocked by #33859
which needs to land before this (and I'm having some difficulty merging internally). Will get back to this

[thymikee]

Ok, let me know if I can help anyhow.

[thymikee]

@cortinico looks like #33859 is merged

[cortinico]

@cortinico looks like #33859 is merged

Yup 👍

Don't you mind rebase this one?
CI should be green now + I've managed to let this build internally

[thymikee]

Rebased :)

[pull-bot]

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 721f47b

[cortinico]

Hey @thymikee Sorry for the delay. We're going to merge this as it is as I was able to let it work correctly for the majority of cases.

However there are a couple of changes we'd like to address on the CLI side of things:

• Autolinking is currently breaking libraries if they don't define a libraryName = field. The problem is here: https://github.com/react-native-community/cli/blob/d5ab2143eeec5d250e6cf13007156f0b042e2c57/packages/platform-android/native_modules.gradle#L259-L264 - Effectively we're importing the Android.mk file regardless of a library actually using codegen or not. This means that if you autolink a library that doesn't have codegen set up (i.e. libraryName = is not set), you'll fail the build with an import of a missign file.
  • Fix is here [android] Do not import a linked Android.mk file if the library is not specifying a libraryName react-native-community/cli#1626
• The whole reliance on libraryName = needs to be adapted a bit.
  • Specifically here: https://github.com/react-native-community/cli/blob/d5ab2143eeec5d250e6cf13007156f0b042e2c57/packages/platform-android/src/config/findLibraryName.ts#L8 - if you specify libraryName = 'abc' instead of libraryName = "abc" (single quotes) which is valid in Gradle, it won't work.
  • Technically libraries could omit the libraryName = field entierely and use the default. This is not handled (though they could override the autolinking config).
  • The whole setup needs to be adapted to read the codegenConfig from package.json and fallback to build.gradle if needed.
  • If the user is using build.gradle.kts -> Autolinking won't work
  • If the user is usign any other Gradle plugin which has a libraryName field, this mechanism will break
  • Most of those points have been handled here: [android] Refine and test the findLibraryName function react-native-community/cli#1635
• CMake support is missing.
  • Done here [android] Add support for autolinking via CMake react-native-community/cli#1630

I have PRs for some of those points that I will be sending towards the cli repo in the next days 👍

[react-native-bot]

This pull request was successfully merged by @thymikee in 9ad7cbc.

^{When will my fix make it into a release? | Upcoming Releases}