-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add talk listing to home page #52
Conversation
Sorry I anyhow press resolve conversation on the query discussion. But I think you could have just had two fields in the one query. |
…rk-community-site into wgao19/home-content
it looks nicer than the last version 😃 peaking from afar, what do u think of moving stories to beneath the main section to make lengths match? gonna take whatever ur call on this is, and thank you muchly for working on this again 🐳💜 |
i really love how the main section flows the boxes btw, ur so great at this 🦔🦔🦔🦔 |
i think after 2 more meetups, the past talks content will become long-ish enough to even things out (so it will look nicer in 2 months?) |
cool, let's merge this :) thank you all! |
- remove wrapper around multiple asides - remove aside related layout code for now - move up "next meetup" aside in DOM - merge "submit talk" into "next meetup" - do not use grid on narrow screen
- smaller than 600: block - 600 - 1279: follow previous 824 - 1279 layout - the 600 breakpoint looks slightly better fit - 1280 - 1599: follow previous 1280 - 1599 layout
- do not have double aside layout - remove 1600 breakpoint
- add parser for intro - list talk + intro - clicking on the talk navigates to GH issue directly - move column layout to topic listing - do not change border bottom width when hover anchor
- this fixes layout on meetup pages
Erm, so, girls, sorry that I then made a lot more changes than expected. Mainly because our changes to home page layout breaks other pages. And I've refactored and simplified our structure a little bit. Then some further changes incurred. In summary:
I will merge this for now. A lot of my implementation is now pretty crude, but hopefully it's conceptually simpler for easier maintenance in the future. And we can pick up from there:
|
addresses #14 on talk parsing as wel |
Implements #41
cc @JennieJi @huijing