Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add talk listing to home page #52

Merged
merged 22 commits into from
Oct 28, 2019
Merged

add talk listing to home page #52

merged 22 commits into from
Oct 28, 2019

Conversation

wgao19
Copy link
Member

@wgao19 wgao19 commented Oct 26, 2019

Implements #41

cc @JennieJi @huijing

@thchia
Copy link
Member

thchia commented Oct 26, 2019

Sorry I anyhow press resolve conversation on the query discussion. But I think you could have just had two fields in the one query.

@wgao19
Copy link
Member Author

wgao19 commented Oct 26, 2019

Thanks for the work and suggestions! Here are some of my thoughts:

  • is there any way to make the boxes take their own content height?

  • on the widest screen, the part on the RHS feels a bit too much information stacked into one small region.. maybe can adjust a little bit, move something to other places, etc:
    image

  • on narrower screens, shall we put "on the next RK" before "past talks"?
    image

@huijing
Copy link

huijing commented Oct 27, 2019

Looks overly-long right now, but will scale well once you have more talks in the past talks section.
Screenshot_2019-10-27 React Knowledgeable · Fun and friendly podium to share what we learn about React

Changing the visual order will affect keyboard navigation, unless u are able to modify the markup at a different viewport size.

@wgao19
Copy link
Member Author

wgao19 commented Oct 27, 2019

it looks nicer than the last version 😃

peaking from afar, what do u think of moving stories to beneath the main section to make lengths match?
on the flip side, this main section is going to grow longer, so im fine w the current layout too

gonna take whatever ur call on this is, and thank you muchly for working on this again 🐳💜

@wgao19
Copy link
Member Author

wgao19 commented Oct 27, 2019

i really love how the main section flows the boxes btw, ur so great at this 🦔🦔🦔🦔

@huijing
Copy link

huijing commented Oct 28, 2019

i think after 2 more meetups, the past talks content will become long-ish enough to even things out (so it will look nicer in 2 months?)
but is @JennieJi ideas v good :)
also u r director...haha...i'm just the guy who moves things around ¯\_(ツ)_/¯

@wgao19
Copy link
Member Author

wgao19 commented Oct 28, 2019

cool, let's merge this :) thank you all!

@wgao19 wgao19 changed the title WiP: add talk listing to home page add talk listing to home page Oct 28, 2019
- remove wrapper around multiple asides
- remove aside related layout code for now
- move up "next meetup" aside in DOM
- merge "submit talk" into "next meetup"
- do not use grid on narrow screen
- smaller than 600: block
- 600 - 1279: follow previous 824 - 1279 layout
- the 600 breakpoint looks slightly better fit
- 1280 - 1599: follow previous 1280 - 1599 layout
- do not have double aside layout
- remove 1600 breakpoint
- add parser for intro
- list talk + intro
- clicking on the talk navigates to GH issue directly
- move column layout to topic listing
- do not change border bottom width when hover anchor
- this fixes layout on meetup pages
@wgao19
Copy link
Member Author

wgao19 commented Oct 28, 2019

Erm, so, girls, sorry that I then made a lot more changes than expected. Mainly because our changes to home page layout breaks other pages. And I've refactored and simplified our structure a little bit. Then some further changes incurred.

In summary:

  • refactored the whole structure to have a default layout for all pages
  • the default layout is a simple header - main + aside - footer
  • added talk content by parsing GH issue body (my bad, I should have foreseen and done this before having you working on this)
  • remove unused css and other minor refactors

I will merge this for now. A lot of my implementation is now pretty crude, but hopefully it's conceptually simpler for easier maintenance in the future. And we can pick up from there:

  • bring back "submit talk" button on home page
  • the home page now looks slightly clumpsy because there is a lot of content now, I think we can find ways to optimize this
  • footer is very delicate now (i.e., in "story" page, if you add a border top to match the border bottom on header, you can see the width is broken)

@wgao19
Copy link
Member Author

wgao19 commented Oct 28, 2019

addresses #14 on talk parsing as wel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants