Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine footer component #56

Open
wgao19 opened this issue Oct 28, 2019 · 0 comments
Open

refine footer component #56

wgao19 opened this issue Oct 28, 2019 · 0 comments
Labels
iced not working on atm for whatever reason

Comments

@wgao19
Copy link
Member

wgao19 commented Oct 28, 2019 •
edited
Loading

Spinoff from #52 again

The footer component has some very cute UI and responsivity thanks to #16. After we refactored the layout in #52, the footer styles are a bit delicate and some pages don't match their responsive design perfectly.

  • i.e., in "story" page, if you add a border top to match the border bottom on header, you can see the width is broken
  • also previously footer sometimes appears not on the bottom, and after i set a default layout, this behavior is gone, not sure how we can do this properly now
@wgao19 wgao19 changed the title simplify footer component refine footer component Oct 28, 2019
@wgao19 wgao19 added the iced not working on atm for whatever reason label Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
iced not working on atm for whatever reason
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wgao19