Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list class #82, hydrate tags in attribs #67, switch to vite/vitest #83

Merged
merged 19 commits into from
Jun 28, 2024

Conversation

timelyportfolio
Copy link
Collaborator

@timelyportfolio timelyportfolio commented Nov 24, 2023

  1. insure component retains list #82 insure reactR::component retains list in class list
  2. Use Plots or other HTML Based inputs in ReactR Components possible? #67 hydrate tag-like props/attributes
  3. replace webpack/karma with the more modern vite/vitest

…lwidgets` will recurse through extracting `htmlwidgets::JS` calls
@timelyportfolio timelyportfolio changed the title retail list in reactR::component class list to #82 retain list in reactR::component class list to #82 Nov 24, 2023
@timelyportfolio timelyportfolio changed the title retain list in reactR::component class list to #82 list class #82, hydrate tags in attribs #67, switch to vite/vitest Mar 12, 2024
@timelyportfolio
Copy link
Collaborator Author

@glin wondering if I could request another big favor to check this pull request? reactable tests and examples all seem to continue to work on my side, and I do not see anything in the code that appears to be affected by the hydration of tags in props/attributes.

@glin
Copy link
Contributor

glin commented Mar 25, 2024

@timelyportfolio Looks good to me. reactable doesn't do any passing of tags as props so it should be unaffected, and I can't think of any side effects either.

@timelyportfolio
Copy link
Collaborator Author

@glin sorry for the very long delay in pushing this to CRAN. I plan to submit today. Thanks for all your help reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants