-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
insure component
retains list
#82
Comments
…lwidgets` will recurse through extracting `htmlwidgets::JS` calls
Hi @timelyportfolio, thanks for the fix here and apologies for the disruption. reactR's use of Would you be able to show me in a small example how reactR uses |
@gadenbuie thanks so much for working through this. Happy to schedule a time to discuss if that works best. My best summary of how I will likely preserve this change regardless of decision in |
@gadenbuie @timelyportfolio Thanks for fixes both in htmlwidgets and reactR. I don't see any downsides to leaving the workaround in either, especially because there are likely still users on htmlwidgets 1.6.3 out there, and it's kind of a hard issue to spot. I will probably leave in the workaround for reactable a little longer as well. |
thanks @glin and @gadenbuie I'll plan to leave the patch to add |
As pointed out in ramnathv/htmlwidgets#477 and glin/reactable#348,
htmlwidgets::JS
will no longer work as expected inreactR::component
. I think @glin fix in glin/reactable@1d60ea6 might be the solution that we could make universal if applied inreactR
.The text was updated successfully, but these errors were encountered: