Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #36

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Improvements #36

wants to merge 31 commits into from

Conversation

evandrocoan
Copy link
Contributor

I think I worked around every big issue I could find.

@evandrocoan
Merged all keybind files to Default.sublime-keymap as they are all
5dd126f 
equal.
@evandrocoan
Migrated the changes from User/Preferences to the Default package.
f1b6575
@evandrocoan
Merge remote-tracking branch 'rctay/master'
0604c63 
# Conflicts:
#	Preferences.sublime-settings
@evandrocoan
Documented the settings file Preferences.sublime-settings
3987d58
@evandrocoan
Fixed the packages not replacing the default Sublime Text keys
7772b7b 
Thread:
Is possible to package override a Sublime Text Default keybinding?
https://forum.sublimetext.com/t/is-possible-to-package-override-a-sublime-text-default-keybinding/31688
@evandrocoan
Forced the sublime text build panel closing repeatedly because
10e66ce 
opens itself up to 1 second after the build has started.
@evandrocoan
Set to copy the view syntax settings on pipe_views.py
b9a74a4
@evandrocoan
Set to also remember the caret position alongside with the view
8443eea 
port position.
@evandrocoan
Merge remote-tracking branch 'rctay/master'
766899d 
# Conflicts:
#	Preferences.sublime-settings
@evandrocoan
Set to pipe_views.py also copy the regex file setting to allow the
ecb6c20 
mouse double click go to feature.
@evandrocoan
Set buildview.enabled as false by default
6b4575a 
Preferences.sublime-settings
@evandrocoan
Increased commands.py build panel hiding close up to 2 seconds.
00e5e59
@evandrocoan
Created a .no-sublime-package for all packages, in attempt to fix
aadb0ee 
evandrocoan/ITE 108 - Expand Region keybind is not working on stable version
@evandrocoan
Fix the Build output tab is not reused after project change or
e777e8c 
Sublime Text Restart. Fixes rctay#23 - The
`Build output` tab is not reused after project change or Sublime
Text Restart
@evandrocoan
Created the setting "buildview.focus_build": false, to control
6bb135e 
whether automatically change your current view to the `Build
output` creating a new build.
@evandrocoan
Fixed the Build output view opening when you pressed Ctrl+Shift+B,
e8c2ff5 
by deprecating the Default *.sublime-keymap files with the
on_window_command() event listener.
@evandrocoan
Removed outdated comment on commands.py
207d182
@evandrocoan
Fixed the build view not working if the view is moved to a new
b76d06d 
window and fixed it not saving the scroll positon when the view is
closed.
rctay
rctay reviewed Oct 30, 2018
View reviewed changes
commands.py
# [1] https://sublimetext.userecho.com/topics/1930-add-panel-param-to-hide_panel-command/
# [2] https://forum.sublimetext.com/t/output-panel-hotkey/15628/2
def hide_panel():
window.run_command("hide_panel")
sublime.set_timeout(hide_panel, 1)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why hiding of the Build panel is dropped?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because you can explicitly disable the build panel with show_panel_on_build. We could say that when someone explicitly enables this package with "buildview.enabled": true, they should disable the build panel with "show_panel_on_build": false.

Due the bug:

  1. show_panel_on_build setting isn't loaded from syntax specific settings sublimehq/sublime_text#679 show_panel_on_build setting isn't loaded from syntax specific settings

Sublime Text is not loading the setting show_panel_on_build from the user projects settings. Then, if someone enables this package per project only, they will not be able to stop the build panel from showing up. However, the fix is very simple, as explained on the issue (sublimehq/sublime_text#679) and can be performed by any user. For example, my Sublime Text is already patched against that.

I got tired of living with those small glitches/bugs which can be extremely easy fixed by the Sublime Text developers. Then, I decided to stop patching our packages with very ugly and hardly working hacks, and let the affected users directly patch Sublime Text files. Of course, only if they can. Otherwise we would still have to keep our packages with those very ugly hacks.

@rctay
Copy link
Owner

rctay commented Aug 7, 2019 via email

@rctay
Copy link
Owner

rctay commented Sep 29, 2019

Hi @evandrocoan would it be OK for you to rebase your branch on top of this repo's master?

@rctay rctay reopened this Sep 29, 2019
@evandrocoan
Copy link
Contributor Author

I think I did not understand correctly.

There are few ways to integrated my branch on your master:

  1. You can merge this pull request squashing (all my commits would become a single).
  2. You can merge this pull request without squashing (all my commits are kept).
  3. You can rebase this pull request and no merge commit would be created and it would be like I was committing directly to your master.
  4. You can cherry pick only the commits you would like, directly into your master
  5. You can cherry pick only the commits you would like, into some other branch and either merge it, squash it or rebase it into your master.

For me, you can merge this any ways you would like.

@evandrocoan
Created the settings.json with Sublime Text version 3999 marking
3076465 
the head commit today as the last supported version of Sublime
Text 3. This is used to start developing the migration for Sublime
Text 4. New updates to Sublime Text 3 should no happen. If required, a tag 3998 should be created inside settings.json with
the changes required for this new version.
@evandrocoan
Fixed ImportError: No module named 'pipe_views'
6d2c124 
Traceback (most recent call last):
  File "F:\SublimeText\Lib\python33\sublime_plugin.py", line 308, in reload_plugin
    m = importlib.import_module(modulename)
  File "./python3.3/importlib/__init__.py", line 90, in import_module
  File "<frozen importlib._bootstrap>", line 1584, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1565, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1532, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 584, in _check_name_wrapper
  File "<frozen importlib._bootstrap>", line 1022, in load_module
  File "<frozen importlib._bootstrap>", line 1003, in load_module
  File "<frozen importlib._bootstrap>", line 560, in module_for_loader_wrapper
  File "<frozen importlib._bootstrap>", line 868, in _load_module
  File "<frozen importlib._bootstrap>", line 313, in _call_with_frames_removed
  File "F:\SublimeText\Data\Packages\BuildView\commands.py", line 7, in <module>
    from pipe_views import PipeViews, proxy_settings
ImportError: No module named 'pipe_views'
@evandrocoan
Merge remote-tracking branch 'rctay/master'
8b9c3c4 
# Conflicts:
#	README.md
#	commands.py
#	pipe_views.py
@rctay
Copy link
Owner

rctay commented Oct 15, 2021

Thanks for the new commits, @evandrocoan , I'll look at integrating them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rctay rctay rctay left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evandrocoan @rctay