Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show_panel_on_build setting isn't loaded from syntax specific settings #679

Open
ctf0 opened this issue Feb 16, 2015 · 4 comments
Open

show_panel_on_build setting isn't loaded from syntax specific settings #679

ctf0 opened this issue Feb 16, 2015 · 4 comments

Comments

@ctf0
Copy link

ctf0 commented Feb 16, 2015

am trying to set "show_panel_on_build": true as a default
and "show_panel_on_build": false only for JS, but it seems that this setting is global and it cant have different settings ,so could the current behavior be altered in anyway ?

@FichteFoll
Copy link
Collaborator

For some apparent reason this is correct, refer to line 187 of exec.py:

show_panel_on_build = sublime.load_settings("Preferences.sublime-settings").get("show_panel_on_build", True)

The build_env setting however is later read from the view.

I suggest to instead load show_panel_on_build setting from the view settings with self.window.active_view().settings() to make the above scenario possible.

@ctf0: FWIW, you can patch exec.py manually on your machine.

@FichteFoll
Copy link
Collaborator

This issue was moved to jskinner/DefaultPackages#105

@sublimehq sublimehq locked and limited conversation to collaborators Feb 16, 2015
@FichteFoll
Copy link
Collaborator

@ctf0 commented on 16 Feb 2015:

thanx for the heasup but how do i add the self.window.active_view().settings() line ? ,am sorry but i have no knowledge about python.

@FichteFoll FichteFoll reopened this Apr 28, 2016
@FichteFoll
Copy link
Collaborator

@FichteFoll commented on 17 Feb 2015 :

  1. Get PackageResourceViewer

  2. Open Default/exec.py with it

  3. Go to line 187 and replace it with

    show_panel_on_build = self.window.active_view().settings().get("show_panel_on_build", True)
  4. Save

@keith-hall keith-hall changed the title show_panel_on_build setting show_panel_on_build setting isn't loaded from syntax specific settings Apr 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants