Skip to content

Commit

Permalink
Fix #50 Add tag completion support for Docker Store images
Browse files Browse the repository at this point in the history
Signed-off-by: Remy Suen <[email protected]>
  • Loading branch information
rcjsuen committed Oct 13, 2019
1 parent a7e23b1 commit 9c633d2
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 5 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# Changelog
All notable changes to this project will be documented in this file.

## [Unrelease]
### Added
- support completing of tags for published images on the Docker Store ([#50](https://github.com/rcjsuen/dockerfile-language-service/issues/50))

## [0.0.8] - 2018-05-23
### Added
- allow Bash syntax for variable modifiers in RUNs ([rcjsuen/dockerfile-utils#56](https://github.com/rcjsuen/dockerfile-utils/issues/56))
Expand Down Expand Up @@ -248,6 +252,7 @@ let workspaceEdit = {
- textDocument/rename
- textDocument/hover

[0.0.9]: https://github.com/rcjsuen/dockerfile-language-service/compare/v0.0.8...HEAD
[0.0.8]: https://github.com/rcjsuen/dockerfile-language-service/compare/v0.0.7...v0.0.8
[0.0.7]: https://github.com/rcjsuen/dockerfile-language-service/compare/v0.0.6...v0.0.7
[0.0.6]: https://github.com/rcjsuen/dockerfile-language-service/compare/v0.0.5...v0.0.6
Expand Down
10 changes: 6 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"node": "*"
},
"dependencies": {
"dockerfile-ast": "0.0.16",
"dockerfile-ast": "0.0.17",
"dockerfile-utils": "0.0.13",
"vscode-languageserver-types": "^3.10.0"
},
Expand Down
9 changes: 9 additions & 0 deletions test/dockerAssist.registry.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,5 +102,14 @@ describe("Docker Content Assist Registry Tests", () => {
assertImageTags(tags, items, 27, 5);
});
});

describe("Docker Store published images", () => {
it("issue #50", async function () {
this.timeout(10000);
const tags = await dockerRegistryClient.getTags("store/intersystems/iris-community");
const items = await computePromise("FROM store/intersystems/iris-community:", 0, 39);
assertImageTags(tags, items, 39, 0);
});
});
});
});

0 comments on commit 9c633d2

Please sign in to comment.