-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config)!: use object parameter instead of array #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @joanrm20! I added a few comments, mostly to follow the conventions of the new Backgrounds addon API.
As for the docs, you can update all README and demo examples to use the object format. Migration tips will be added to the GitHub release once merged.
-fix normalizeValues overriding config -disable prop is now working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joanrm20 I added a few more suggestions, especially regarding the API. Let me know what you think 🙂
Also, we need to update the README examples, but it's better to decide the final API first.
add missed types
- simplify helpers - refactor API
hey @rbardini, done. I have merged and test your latest changes. Please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Will merge it soon 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, found two lines to be removed before we merge this, otherwise looks good 🙂
hey @rbardini, I've updated it. Please take a look. |
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hey @rbardini,
So I started to work on #8. Let me know if this is in the right path of what you were aiming to solve. :)
What I did:
sizes
as part of thepaddings
global object, just so it looks a bit more readable from the config outside. Please let me know what do you think on this one? :)Pending:
Alternative Option: