Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook build fail Node LTS/erbium #12

Closed
joanrm20 opened this issue Jul 15, 2020 · 1 comment · Fixed by #13
Closed

Storybook build fail Node LTS/erbium #12

joanrm20 opened this issue Jul 15, 2020 · 1 comment · Fixed by #13
Labels
bug Something isn't working released

Comments

@joanrm20
Copy link
Contributor

joanrm20 commented Jul 15, 2020

When working on #10 feedback, I tried to build by using npm run build-example again to test it. But it started to fail with the following error:

ERR! => Failed to build the preview
ERR! ./.storybook/generated-entry.js
ERR! Module build failed (from ./node_modules/babel-loader/lib/index.js):
ERR! Error: Cannot find module '@babel/compat-data/corejs3-shipped-proposals'

Checking a bit further the error led me to storybookjs/storybook#10477, specifically the following comment storybookjs/storybook#10477 (comment)

We can solve the issue by updating dependencies.

I already made progress and fixed the issue, but since we are already updating some dependencies and I figured there's no major problem updating the rest I thought it'll be a nice chance to update the rest as well.

I have opened a PR, please let me know what do you think? Thanks :)

@rbardini rbardini added the bug Something isn't working label Jul 18, 2020
@github-actions
Copy link

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants