feat(TextInput): add note on type="number" attribute
#1120
Conversation
saurabhdaware
requested review from
chaitanyadeorukhkar,
kamleshchandnani,
anuraghazra,
dhruvdutt,
nashcheez and
divyanshu013
as code owners
🦋 Changeset detectedLatest commit: 7e03646 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7e03646:
|
|
✅ PR title follows Conventional Commits specification. |
| }; | ||
|
|
||
| // @ts-expect-error: Just another undocumented, untyped storybook property ;__; | ||
| TextInputTypeNumber.story = { |
There was a problem hiding this comment.
Dude how do you even find such properties? What is this sorcery?
Also, hope its not crashing on react native as some unsupported property or something 🙈
There was a problem hiding this comment.
Dude how do you even find such properties? What is this sorcery?
Lol github issue comments ftw storybookjs/storybook#8527 (comment)
Also, hope its not crashing on react native as some unsupported property or something 🙈
My XCode asking me to reinstall and that is failing lol so can't check. Hopefully it won't since Component.anything = {} is fair assignment 🙈
There was a problem hiding this comment.
ok finally xcode worked. checked the story its working.
* feat: type number story * feat: add jsdoc * Create honest-socks-sin.md
type="number"internallyThere are several people who have asked this so far on slack -
and more so better to have a note in docs itself.