Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB-6573: Matches slide generator to carolus #230

Merged
merged 1 commit into from
Oct 16, 2023
Merged

WEB-6573: Matches slide generator to carolus #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/server/views/content_modules/segment_slide.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="title-slide" id="slide-to-snapshot">
<div class="title-slide segment-slide" id="slide-to-snapshot">
<h1>
<%= content_module.title %>
</h1>
Expand Down
42 changes: 30 additions & 12 deletions app/server/views/styles/components/slide.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
========================================================================== */

/* Title slide is a bigger size than video to go to a video file. So we need to scale all the sizes up */
/* 2022 Oct sizing for carolus is height: 602px, width: 1072px.*/
/* 2022 Oct sizing for carolus is height: 588px, width: 1036px.*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The height for video is not changed for module.
As I am not aware of exactly what goes in this, does main container width play a role in deciding what width and height should be?

$slide-ratio: 1.8;

.title-slide {
Expand Down Expand Up @@ -145,29 +145,29 @@ $slide-ratio: 1.8;
bottom: 32px * $slide-ratio;

h2 {
font-size: 16px * $slide-ratio;
line-height: 1.25;
font-size: 12px * $slide-ratio;
line-height: 1;
letter-spacing: 2px !important;
text-transform: uppercase;
font-family: 'Relative', sans-serif;
font-weight: 400;
font-weight: 500;
text-align: left;
padding-bottom: 16px * $slide-ratio;
/* Max-width is roughly 55%, but percentage doesn't work cos absolute positioning... */
max-width: 587px * $slide-ratio;
padding-bottom: 8px * $slide-ratio;
/* Max-width is roughly 75%, but percentage doesn't work cos absolute positioning... */
max-width: 713px * $slide-ratio;
}

h3 {
font-size: 40px * $slide-ratio;
font-family: 'Relative', sans-serif;
font-weight: 400;
line-height: 1.25;
/* Max-width is roughly 55%, but percentage doesn't work cos absolute positioning... */
max-width: 587px * $slide-ratio;
/* Max-width is roughly 75%, but percentage doesn't work cos absolute positioning... and -64px to match carolus */
max-width: 713px * $slide-ratio;
}
}

figure {
width: 252px * $slide-ratio;
height: 252px * $slide-ratio;
width: 21%;
position: absolute;
bottom: 32px * $slide-ratio;
right: 32px * $slide-ratio;
Expand Down Expand Up @@ -230,3 +230,21 @@ $slide-ratio: 1.8;
}
}
}

.segment-slide {
h1 {
max-width: 100%;
padding-right: 32px * $slide-ratio;
}
.slide-episode {
h2 {
text-transform: unset;
letter-spacing: normal !important;
font-weight: 400;
}

h3 {
font-size: 24px * $slide-ratio;
}
}
}